This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix probable typo in i386_process_record
- From: Hui Zhu <teawater at gmail dot com>
- To: Michael Snyder <msnyder at vmware dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Sat, 10 Oct 2009 13:51:23 +0800
- Subject: Re: [RFA] Fix probable typo in i386_process_record
- References: <4ACFDBDC.1090500@vmware.com>
I think this patch is OK. Thanks a lot.
Hui
On Sat, Oct 10, 2009 at 08:57, Michael Snyder <msnyder@vmware.com> wrote:
> Hui, I'm *pretty* sure I got this right, but you'd better confirm:
>
>
> 2009-10-09 ?Michael Snyder ?<msnyder@vmware.com>
>
> ? ? ? ?* i386-tdep.c (i386_process_record): Or-equals, not not-equals.
>
> Index: i386-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/i386-tdep.c,v
> retrieving revision 1.288
> diff -u -p -r1.288 i386-tdep.c
> --- i386-tdep.c 28 Sep 2009 07:11:36 -0000 ? ? ?1.288
> +++ i386-tdep.c 10 Oct 2009 00:58:09 -0000
> @@ -4146,7 +4146,7 @@ reswitch:
> ? ? ? ?return -1;
> ? ? ? if (ir.mod == 3)
> ? ? ? ?{
> - ? ? ? ? ir.rm != ir.rex_b;
> + ? ? ? ? ir.rm |= ir.rex_b;
> ? ? ? ? ?if (ir.ot == OT_BYTE && !ir.regmap[X86_RECORD_R8_REGNUM])
> ? ? ? ? ? ?ir.rm &= 0x3;
> ? ? ? ? ?I386_RECORD_ARCH_LIST_ADD_REG (ir.rm);
>
>