This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch][doc] PR python/10781


>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:

>> +Cast the @code{gdb.Value} to the type represented by @var{type}, and
Eli>         ^^^
Eli> Please remove this "the".

Removing the "the" makes this read strangely.
gdb.Value is a class, the "the" indicates that it is an instance which is
cast.

>> +return a new @code{gdb.Value}.  @var{type} must be a @code{gdb.Type}
>> +object.

Eli> If TYPE is an object, then it probably isn't a good idea to call it
Eli> TYPE.  Why not OBJECT?

I think it is generally preferable to name parameters according to their
use.  "object" is not specific enough.

Eli> Anyway, what does it mean "the type represented by TYPE"?  How can a
Eli> type be "represented"?  Did you perhaps mean "the type of TYPE"?

gdb.Type represents a type in the inferior.
"the type of TYPE" would be incorrect.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]