This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: New ARI regression Fri Oct 23 01:57:01 UTC 2009
- From: Michael Snyder <msnyder at vmware dot com>
- To: Pierre Muller <muller at ics dot u-strasbg dot fr>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 23 Oct 2009 09:00:20 -0700
- Subject: Re: New ARI regression Fri Oct 23 01:57:01 UTC 2009
- References: <20091023015701.GA26378@sourceware.org> <006301ca53be$eedd1b80$cc975280$@u-strasbg.fr>
Pierre Muller wrote:
Is there a valid reason to use LITTLE_ENDIAN rather than
BFD_LITTLE_ENDIAN as required by the ARI rule:
LITTLE ENDIAN 3 Do not use LITTLE_ENDIAN, instead use
BFD_ENDIAN_LITTLE
See:
http://sourceware.org/gdb/current/ari/
Pierre Muller
as ARI "maintainer"
Thanks Pierre. Checked in as obvious.
So let it be written -- so let it be done.
2009-10-23 Michael Snyder <msnyder@vmware.com>
* record.c (netorder64): Use BFD_ENDIAN_LITTLE not LITTLE_ENDIAN.
(netorder32): Ditto.
(netorder16): Ditto.
Index: record.c
===================================================================
RCS file: /cvs/src/src/gdb/record.c,v
retrieving revision 1.30
diff -u -p -r1.30 record.c
--- record.c 22 Oct 2009 19:36:06 -0000 1.30
+++ record.c 23 Oct 2009 16:05:47 -0000
@@ -1955,7 +1955,7 @@ bfdcore_read (bfd *obfd, asection *osec,
static inline uint64_t
netorder64 (uint64_t fromfile)
{
- return (BYTE_ORDER == LITTLE_ENDIAN)
+ return (BYTE_ORDER == BFD_ENDIAN_LITTLE)
? bswap_64 (fromfile)
: fromfile;
}
@@ -1963,7 +1963,7 @@ netorder64 (uint64_t fromfile)
static inline uint32_t
netorder32 (uint32_t fromfile)
{
- return (BYTE_ORDER == LITTLE_ENDIAN)
+ return (BYTE_ORDER == BFD_ENDIAN_LITTLE)
? bswap_32 (fromfile)
: fromfile;
}
@@ -1971,7 +1971,7 @@ netorder32 (uint32_t fromfile)
static inline uint16_t
netorder16 (uint16_t fromfile)
{
- return (BYTE_ORDER == LITTLE_ENDIAN)
+ return (BYTE_ORDER == BFD_ENDIAN_LITTLE)
? bswap_16 (fromfile)
: fromfile;
}