This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h
- From: Pedro Alves <pedro at codesourcery dot com>
- To: Michael Snyder <msnyder at vmware dot com>
- Cc: Hui Zhu <teawater at gmail dot com>, Pierre Muller <muller at ics dot u-strasbg dot fr>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 26 Oct 2009 17:20:36 +0000
- Subject: Re: Build failure: src/gdb ChangeLog record.c gcore.c gcore.h
- References: <20091022193607.13598.qmail@sourceware.org> <daef60380910260002h3c6cb481q5e8ecae5769897ba@mail.gmail.com> <4AE5C3BF.4010007@vmware.com>
On Monday 26 October 2009 15:43:59, Michael Snyder wrote:
> Hui Zhu wrote:
> > OK. I make a new patch for it.
> > Please help me review it.
>
> It looks ok to me, but I have only linux systems on which to
> evaluate it. I'd like a 2nd opinion. Pedro?
Looks good to me. Thanks.
Tiny consistency issue:
> - record.c \
> + record.c gcore.c\
All other lines have a space before '\'. Write as:
> - record.c \
> + record.c gcore.c \
--
Pedro Alves