This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: fileio test


Daniel Jacobowitz wrote:
On Thu, Nov 05, 2009 at 06:04:18PM +0000, Nathan Sidwell wrote:
This patch fixes an augments the fileio shell test.  By default
system calls are disallowed -- but the test expects them to be
enabled.  This patch fixes that test and verifies that enabling
system calls, does indeed enable them.

ok?

What happens when you run this test natively? I believe it will fail since it uses your host's system () directly. This test doesn't test just fileio.

ah, yes you're right. The current behaviour passes natively because of that.


It's not obvious to me how the testsuite could distinguish between these two cases. remote-fileio.c doesn't have any verbose logging we could turn on (and have the testsuite watch for it). I suppose we could add it. Or we could turn on remote-protocol logging and watch for that (which seems less desirable).

Thoughts?

nathan

--
Nathan Sidwell    ::   http://www.codesourcery.com   ::         CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]