This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Allow "disassemble 'Foo::bar(char *)'"

From: Tom Tromey <tromey at redhat dot com>
To: Paul Pluzhnikov <ppluzhnikov at google dot com>
Cc: Andreas Schwab <schwab at linux-m68k dot org>, gdb-patches at sourceware dot org
Date: Mon, 16 Nov 2009 11:25:22 -0700
Subject: Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
References: <20091114001022.A0A0776CDD@ppluzhnikov.mtv.corp.google.com> <m23a4g5fur.fsf@whitebox.home> <8ac60eac0911150916k70ac0f62hf349b0bc21aa58b7@mail.gmail.com>
Reply-to: tromey at redhat dot com

>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:

Paul> But perhaps splitting on comma (after skipping any quoted expression
Paul> -- Foo::bar could have multiple parameters) is "good enough"? That
Paul> would allow 'disas &main + 1, &main + 5' to work.

I'm ok with changing this, mostly because I think the current approach
is bogus -- but I can understand that some people might not like it
because it is not backward compatible.

Are you planning to work on this?  If not, I think your original patch
is ok.

Tom

Follow-Ups:
- Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
  - From: Paul Pluzhnikov

References:
- [patch] Allow "disassemble 'Foo::bar(char *)'"
  - From: Paul Pluzhnikov
- Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
  - From: Andreas Schwab
- Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
  - From: Paul Pluzhnikov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]