This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Allow "disassemble 'Foo::bar(char *)'"

From: Paul Pluzhnikov <ppluzhnikov at google dot com>
To: Tom Tromey <tromey at redhat dot com>
Cc: Andreas Schwab <schwab at linux-m68k dot org>, gdb-patches at sourceware dot org
Date: Fri, 20 Nov 2009 09:40:40 -0800
Subject: Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
References: <20091114001022.A0A0776CDD@ppluzhnikov.mtv.corp.google.com> <m23a4g5fur.fsf@whitebox.home> <8ac60eac0911150916k70ac0f62hf349b0bc21aa58b7@mail.gmail.com> <m3my2mtjhp.fsf@fleche.redhat.com> <8ac60eac0911161028of5f2352lf1857db7a46a94b2@mail.gmail.com> <8ac60eac0911191539w4245739ka6405ba072b79395@mail.gmail.com> <m3pr7d9ket.fsf@fleche.redhat.com>

On Fri, Nov 20, 2009 at 9:27 AM, Tom Tromey <tromey@redhat.com> wrote:

> You probably want to skip whitespace after the ",".

parse_and_eval_address() does it on its own (as
"disas 0x40055a + 1, 0x40055a + 5" demonstrates).

I didn't see the point in adding extra "while (isspace)" loop.

Thanks,
-- 
Paul Pluzhnikov

References:
- [patch] Allow "disassemble 'Foo::bar(char *)'"
  - From: Paul Pluzhnikov
- Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
  - From: Andreas Schwab
- Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
  - From: Paul Pluzhnikov
- Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
  - From: Tom Tromey
- Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
  - From: Paul Pluzhnikov
- Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
  - From: Paul Pluzhnikov
- Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]