This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Replace deprecated_memory_changed_hook with an observer.
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Paul Pluzhnikov <ppluzhnikov at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 25 Nov 2009 12:48:37 -0800
- Subject: Re: [patch] Replace deprecated_memory_changed_hook with an observer.
- References: <8ac60eac0911251142r62f0e95al5ebd44503cac645c@mail.gmail.com>
> 2009-11-25 Paul Pluzhnikov <ppluzhnikov@google.com>
>
> * ada-lang.c (ada_value_assign): Use observer_notify_memory_changed.
> * valops.c (value_assign): Likewise.
> * defs.h (deprecated_memory_changed_hook): Remove.
> * interps.c (clear_interpreter_hooks): Adjust.
It looks like you forgot to remove the definition in top.c.
Pre-approved with that change.
> gdb/doc/ChangeLog:
>
> 2009-11-25 Paul Pluzhnikov <ppluzhnikov@google.com>
>
> * observer.texi: New memory_changed observer.
This part looks fine to me, but will have to wait for Eli's approval.
> gdb/gdbtk/ChangeLog:
>
> 2009-11-25 Paul Pluzhnikov <ppluzhnikov@google.com>
>
> * generic/gdbtk-hooks.c (gdbtk_memory_changed): Adjust.
> (gdbtk_add_hooks): Adjust.
This part is approved. Very kind of you to fix problems in gdbtk :).
--
Joel