This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Fix for PR gdb/11022
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Paul Pluzhnikov <ppluzhnikov at google dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 26 Nov 2009 13:21:11 -0800
- Subject: Re: [patch] Fix for PR gdb/11022
- References: <20091125234600.8128276D99@ppluzhnikov.mtv.corp.google.com>
> 2009-11-25 Paul Pluzhnikov <ppluzhnikov@google.com>
>
> PR gdb/11022
>
> * breakpoint.c (invalidate_bp_value_on_memory_change):
> New function.
> (_initialize_breakpoint): Add it as memory change observer.
Seems fine to me, but I have become more and more unfamiliar with
this area, not having been involved with it for a while. So let's wait
a week or so to see if anyone has any comment, and then it can go in.
> 2009-11-25 Paul Pluzhnikov <ppluzhnikov@google.com>
>
> PR gdb/11022
>
> * gdb.base/pr11022.exp: New test.
> * gdb.base/pr11022.c: New test.
Just one tiny comment:
> + j = 0; // break here
> + x = 42;
> + j = i; // expect HW watchpoint stop
Can you use C-style comments, here (since this is a C file)?
GCC accepts them even in C, but other C compilers might not.
Thank you,
--
Joel