This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

GDB HEAD on GNU/Hurd


Hello!

This is only a friendly ;-) reminder to Pedro, so that he doesn't forget
about this issue in the lots of work he's doing.
<http://www.gnu.org/software/hurd/open_issues/gdb_head.html>; which I
bisected to his and Stan's multi-exec patch.

Pedro suggested a hack (and I confirmed that it works), it is ``#if 0''ed
out in gnu_create_inferior in the patch -- as I found another place where
the equivalent thing was already once planned to be done, next to our
funky pending_execs handling:

Index: gnu-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/gnu-nat.c,v
retrieving revision 1.69
diff -u -p -r1.69 gnu-nat.c
--- gnu-nat.c	19 Oct 2009 09:51:41 -0000	1.69
+++ gnu-nat.c	27 Nov 2009 08:01:21 -0000
@@ -75,6 +75,8 @@
 #include "exc_request_U.h"
 #include "msg_U.h"
 
+extern void prune_threads (void);
+
 static process_t proc_server = MACH_PORT_NULL;
 
 /* If we've sent a proc_wait_request to the proc server, the pid of the
@@ -1570,8 +1572,8 @@ rewait:
 	  if (--inf->pending_execs == 0)
 	    /* We're done!  */
 	    {
+	      prune_threads ();	/* Get rid of the old shell threads */
 #if 0				/* do we need this? */
-	      prune_threads (1);	/* Get rid of the old shell threads */
 	      renumber_threads (0);	/* Give our threads reasonable names. */
 #endif
 	    }
@@ -2126,6 +2128,10 @@ gnu_create_inferior (struct target_ops *
     inf_steal_exc_ports (inf);
   else
     inf_restore_exc_ports (inf);
+
+#if 0
+  prune_threads ();
+#endif
 }
 
 

Pedro's concern was that this might be needed in other places as well.


Regards,
 Thomas

Attachment: signature.asc
Description: Digital signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]