This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [MI] core awareness
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Vladimir Prus <vladimir at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 18 Dec 2009 13:42:11 +0200
- Subject: Re: [MI] core awareness
- References: <200912162352.38585.vladimir@codesourcery.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Wed, 16 Dec 2009 23:52:38 +0300
>
> This is mostly MI change, but includes some remote protocol tweaks,
> and documentation. I'd appreciate review of those parts.
Thanks, see below for the documentation review.
> -several threads in the list.
> +several threads in the list. The @var{core} field reports on which
> +processor core the stop event has happened.
Suggest to rephrase slightly:
The @var{core} field reports the processor core on which the stop
event has happened.
> +@item id
> +The numeric id assigned to the thread by @value{GDBN}. This field is
> +always present. ^^
Two spaces, please.
> +Lists thread groups (@pxref{Thread groups}). When a single thread
> +group is passed as the argument, lists the children specified one.
Something is missing in the last sentence ("children of the specified
one"?).
> +are passed, the output always have a @samp{groups} result. The format
^^^^
"has"
> +thread. It may be present
Pedro already noticed this incomplete sentence.
> +@value{GDBN} gdb requests, using the @samp{qXfer:threads:read}
^^^
Remove the "gdb" part.
> +package (@pxref{qXfer threads read}) and XML document with the
> +format described below.
Sounds like an incomplete sentence (GDB requests what?).
Thanks.