This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Re: Regression: field type preservation: 7.0 -> 7.0.1+HEAD


>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> In my opinion, I agree with Daniel's comment that it is unusual to
Joel> call check_typedef without storing the function result.

FWIW, we do have a few of these.  We should at least comment that this
is called for side effects where this is done, I've tried to do that
with new calls.

Joel> So, my proposal, if the other maintainers agree, is to document
Joel> the side-effect of check_typedef (sets the typedef TYPE_LENGTH)
Joel> as this appears to be a fully-intended behavior, and then do:

This is documented by the TYPE_LENGTH macro, which is how I knew about
it :-).  This comment also mentions that allocate_value calls
check_typedef.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]