Re: Multiexec MI

[Eli Zaretskii <eliz at gnu dot org>]

> From: Vladimir Prus <vladimir@codesourcery.com>
> Date: Wed, 13 Jan 2010 23:29:30 +0300
> 
> This patch implements MI support for multiexec. I attach my notes on design, as well
> as patch. The patch also contains documentation updates.

Thanks.  I have a few comments about the docs.

> -@item =thread-group-created,id="@var{id}"
> +@item =thread-group-added,id="@var{id}"
> +@itemx =thread-group-removed,id="@var{id}"
> +A thread thread group was either added or removed.  The @var{id} field
     ^^^^^^^^^^^^^
I believe one of these two "thread"s should be removed.

> +@item =thread-group-started,id="@var{id}",pid="@var{pid}"
> +A thread group either because associated with a running program,
> +either because the program was started or it the thread group
> +was attached to a program.

Something is wrong with this sentence.

> +A thread thread group is no longer associated with a running program,
     ^^^^^^^^^^^^^
Another redundant "thread".

> +library are loaded.  The @var{thread-group} field, if present,
> +contains the id of the thread group in which the library was loaded.
> +If the field is absent, it means the library was loaded in all present
> +thread groups.

"Library loaded IN a thread group" sounds awkward.  Did you mean
"loaded BY a thread group"?

>  @item =library-unloaded,...
>  Reports that a library was unloaded by the program.  This notification
>  has 3 fields---@var{id}, @var{target-name} and @var{host-name} with
> -the same meaning as for the @code{=library-loaded} notification
> +the same meaning as for the @code{=library-loaded} notification.  The 
> +@var{thread-group} field, if present, contains the id of the thread
> +group in which the library was loaded.  If the field is absent,
                                  ^^^^^^
You mean "unloaded", right?

> +it means the library was loaded in all present thread groups.
                            ^^^^^^
And here.

> -@samp{--all} is specified, all threads will be resumed.  The
> +@samp{--all} is specified, all threads (in all inferiours) will be resumed.  
                                                  ^^^^^^^^^^
"inferiors" (here and elsewhere in this patch)

> +Identifier of the thread group.  This field is always present.  The
> +identifier is an opaque string, and is not necessary an integer.
                                              ^^^^^^^^^
"necessarily"

Also, "is an opaque string, and is not necessarily an integer" sounds
strange: if it's a string, how can it be an integer?  Do you mean to
say that the string includes non-digit characters?

> +@item executable
> +The name of the executable file that corresponds to this thread group.
> +The field is only present for thread groups of type @samp{process},
> +and only if there is corresponding executable file.
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^          
"if there is a corresponding executable file".

> +inferior is not associated with any executable.  Such associated may
> +be established with the @samp{-file-exec-and-symbols} command 

"Such association may be established ..."

> +The inferior @var{inf} has been added to the list of inferiour.  At
                                                        ^^^^^^^^^
in observer.texi, too.

Thanks.