This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: D language support


>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

>> +static char* out_str;
>> +static char* out_pos;
>> +static char* mangled_str;

Joel> I prefered it when you had a type, encapsulating the whole bounded
Joel> string concept. You can always make it static if you think it helps.

Just use an obstack.

We already have plenty of expanding data types -- VEC, obstack,
dyn_string from libiberty.  Unless there is strong proof for a need,
don't introduce a new one or a hand-written one.

>> +  mangled_str = (char *) symbol;

Joel> Outch! You are bypassing the "const", preventing potentially useful
Joel> compiler warnings. Isn't there a way to avoid this?

I looked at this and I don't think there's any need for it.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]