Re: [PATCH] Can't build sh-elf-sim on OSX.

[Joel Brobecker <brobecker at adacore dot com>]

Masaki,

In terms of copyright assignment, this contribution is unfortunately
beyond what can be accepted without a copyright assignment in place.
See: http://www.gnu.org/prep/maintain/maintain.html#Legally-Significant

(the git patch summary is a gem!)

Note also that it would not help in terms of copyright to break your patch
into smaller patches, as it is the total contribution that matters here.

> 2010-01-12  Masaki Muranaka   <monaka@monami-softwar.com>
                                               ^^^^^^^ :-)
> 
> 	* interp.c: Don't include sysdep.h
> 	include stdio.h and errno.h
> 	include string.h strings.h stdlib.h sys/stat.h if present.

I don't see anything wrong with the patch. But I'm wondering how
we managed to miss so many includes. I tried building the SH simulator
on x86_64-linux, and your patch apparently fixes none of the warnings
that I see. So can you explain why you had to add the includes that
you added (just a reference to the code that needs these includes is
fine).

I am expecting to approve the patch as soon as you have detailed
the reason behind each include.

-- 
Joel