Re: [PATCH] Can't build sh-elf-sim on OSX.

[Masaki Muranaka <monaka at monami-software dot com>]

Hello Joel,

I'm waiting the assignment form FSF now.
I don't mind if my patch is applied after registering my name.
(that patch is not quite tiny, indeed.)

I tried just remove sysdep.h like sim/mips/interp.c. Then I had a some
errors under OSX host. I attach the build log.
And I tried on x86_64-linux just before. It also.
At least, we need stdio.h since it uses stderr and FILE in interp.c
and there seems be no path to include stdio.h. errno.h is also for EINVAL.
Other header files are for suppressing "incompatible implicit
declaration of built-in function.".

Thanks,

On 2010/01/19, at 17:07, Joel Brobecker wrote:
> I don't see anything wrong with the patch. But I'm wondering how
> we managed to miss so many includes. I tried building the SH simulator
> on x86_64-linux, and your patch apparently fixes none of the warnings
> that I see. So can you explain why you had to add the includes that
> you added (just a reference to the code that needs these includes is
> fine).
> 
> I am expecting to approve the patch as soon as you have detailed
> the reason behind each include.
> 
> -- 
> Joel
> 

--
Masaki Muranaka
Monami software

Attachment: sh-sim-error.log
Description: Binary data