This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/doc] Redefine the length argument in remote Z packets


On Fri, Jan 29, 2010 at 10:54:27PM +0200, Eli Zaretskii wrote:
> > -@item z2,@var{addr},@var{length}
> > -@itemx Z2,@var{addr},@var{length}
> > +@item z2,@var{addr},@var{kind}
> > +@itemx Z2,@var{addr},@var{kind}
> >  @cindex @samp{z2} packet
> >  @cindex @samp{Z2} packet
> > -Insert (@samp{Z2}) or remove (@samp{z2}) a write watchpoint.
> > +Insert (@samp{Z2}) or remove (@samp{z2}) a write watchpoint covering
> > +@var{kind} bytes at @var{addr}.
> 
> "covering KIND bytes" sounds awkward.  How about
> 
>   Insert (@samp{Z2}) or remove (@samp{z2}) a write watchpoint.
>   @var{kind} is 2 for watching a 2-byte region, 4 for watching a
>   4-byte region.
> 
> and similarly with Z3 and Z4?

Except it really can be any number of bytes now.  "@var{kind} is
interpreted as the number of bytes to watch"?

> you want "see @ref" instead of "@xref", because the latter produces a
> capitalized "See", which will look wrong after a semi-colon.

Thanks!

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]