This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: PATCH: Add builtin floating point types
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: hjl dot tools at gmail dot com
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 5 Feb 2010 01:07:47 +0100 (CET)
- Subject: Re: PATCH: Add builtin floating point types
- References: <6dc9ffc81002041502kce3885cm81d3055c2eb2c84f@mail.gmail.com>
> Date: Thu, 4 Feb 2010 15:02:25 -0800
> From: "H.J. Lu" <hjl.tools@gmail.com>
>
> On Thu, Feb 4, 2010 at 2:24 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> > x86 has i387_ext. I added
> >
> > =A0 case TDESC_TYPE_I387_EXT:
> > =A0 =A0 =A0return arch_float_type (gdbarch, -1, "builtin_type_i387_ext",
> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0floatformats_i=
> 387_ext);
> >
> > to tdesc_gdb_type. I would up 8 i387_ext types at different addresses
> > with the same bits. x86 does
> >
> > if (i386_fp_regnum_p (gdbarch, regnum))
> > =A0 =A0{
> > =A0 =A0 =A0/* Floating point registers must be converted unless we are
> > =A0 =A0 =A0 =A0 accessing them in their hardware type. =A0*/
> > =A0 =A0 =A0if (type =3D=3D i387_ext_type (gdbarch))
> > =A0 =A0 =A0 =A0return 0;
> > =A0 =A0 =A0else
> > =A0 =A0 =A0 =A0return 1;
> > =A0 =A0}
> >
> > It expects 2 =A0i387_ext types should have the same address. Ha
> > can I cache the i387_ext type for single gdbarch?
> >
>
> Here is a patch to add builtin floating point types. OK to install?
Please send diffs that I can read; no base64 encoded MIME crap.