This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: PATCH: Cache types from target description
> Date: Tue, 9 Feb 2010 07:45:13 -0800
> From: "H.J. Lu" <hongjiu.lu@intel.com>
> Cc: GDB <gdb-patches@sourceware.org>, Mark Kettenis <mark.kettenis@xs4all.nl>
>
> Here is the updated patch. I fixed i386_eflags and documented them.
> OK to install?
The doco part is okay, but please fix the following 2 minor issues
before committing:
> 2010-02-09 H.J. Lu <hongjiu.lu@intel.com>
>
> * gdb.texinfo: Add i387_ext, i386_eflags and i386_mxcsr.
Please state the name of the node in which you are making the change
(in parens, as if it were a function). You can find it by looking
back from the locus of the change for a line that begins with
"@node".
> +@item i386_eflags
> +32bit EFLAGS register used by x86.
> +
> +@item i386_mxcsr
> +32bit MXCSR register used by x86.
It would look prettier in print if you use @sc{eflags} and @sc{mxcsr}
instead of up-casing them in the Texinfo sources.
Thanks.