This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Sanity check PIE displacement (like the PIC one)
On Thu, 11 Feb 2010 23:26:07 +0100, Daniel Jacobowitz wrote:
> On Thu, Feb 11, 2010 at 11:21:13PM +0100, Jan Kratochvil wrote:
> > The life-saver message is IMO "B" but the message(s) being discussed to be
> > removed is A1+A2.
> >
> > Is the attached patch what everone agrees upon or have I not understood it?
>
> Fine with me. Or you could just use verbose.
Checked it in pre-approved for "verbose" without changing the content to move
forward with the PIE part.
Thanks,
Jan
http://sourceware.org/ml/gdb-cvs/2010-02/msg00100.html
--- src/gdb/ChangeLog 2010/02/12 21:28:25 1.11356
+++ src/gdb/ChangeLog 2010/02/13 12:02:26 1.11357
@@ -1,3 +1,8 @@
+2010-02-13 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ * solib-svr4.c: (LM_ADDR_CHECK): Print successful prelink adjustment
+ only if INFO_VERBOSE.
+
2010-02-12 Tomas Holmberg <th@virtutech.com>
* mi/mi-main.c: Added the --reverse flag to the following MI
--- src/gdb/solib-svr4.c 2010/02/11 23:07:23 1.119
+++ src/gdb/solib-svr4.c 2010/02/13 12:02:28 1.120
@@ -234,10 +234,13 @@
{
l_addr = l_dynaddr - dynaddr;
- warning (_(".dynamic section for \"%s\" "
- "is not at the expected address"), so->so_name);
- warning (_("difference appears to be caused by prelink, "
- "adjusting expectations"));
+ if (info_verbose)
+ {
+ warning (_(".dynamic section for \"%s\" "
+ "is not at the expected address"), so->so_name);
+ warning (_("difference appears to be caused by prelink, "
+ "adjusting expectations"));
+ }
}
else
warning (_(".dynamic section for \"%s\" "
--- src/gdb/testsuite/ChangeLog 2010/02/12 21:39:27 1.2129
+++ src/gdb/testsuite/ChangeLog 2010/02/13 12:02:29 1.2130
@@ -1,3 +1,7 @@
+2010-02-13 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ * gdb.base/prelink.exp (set verbose on): New.
+
2010-02-12 Tomas Holmberg <th@virtutech.com>
* mi-reverse.exp: New file. Test for reverse option to the
--- src/gdb/testsuite/gdb.base/prelink.exp 2010/01/01 07:32:01 1.10
+++ src/gdb/testsuite/gdb.base/prelink.exp 2010/02/13 12:02:29 1.11
@@ -109,6 +109,9 @@
gdb_reinitialize_dir $srcdir/$subdir
gdb_load ${binfile}
+# Print the "adjusting expectations" message.
+gdb_test "set verbose on"
+
set test "prelink"
global gdb_prompt
gdb_test_multiple "core-file $objdir/$subdir/prelink.core" "$test" {