Re: Multiexec MI

[Vladimir Prus <vladimir at codesourcery dot com>]

On Thursday 14 January 2010 00:04:38 Eli Zaretskii wrote:

> > From: Vladimir Prus <vladimir@codesourcery.com>
> > Date: Wed, 13 Jan 2010 23:29:30 +0300
> > 
> > This patch implements MI support for multiexec. I attach my notes on design, as well
> > as patch. The patch also contains documentation updates.
> 
> Thanks.  I have a few comments about the docs.

Thanks for the review.


> > +library are loaded.  The @var{thread-group} field, if present,
> > +contains the id of the thread group in which the library was loaded.
> > +If the field is absent, it means the library was loaded in all present
> > +thread groups.
> 
> "Library loaded IN a thread group" sounds awkward.  Did you mean
> "loaded BY a thread group"?

My intention was to say that shared library has appeared *in* a context of a
thread thread. "BY" does not work as well for the second sentence --
"was loaded in all present thread groups" will sound awkward with "by".
Is there another way to reword this?

> > +Identifier of the thread group.  This field is always present.  The
> > +identifier is an opaque string, and is not necessary an integer.
>                                               ^^^^^^^^^
> "necessarily"
> 
> Also, "is an opaque string, and is not necessarily an integer" sounds
> strange: if it's a string, how can it be an integer?  Do you mean to
> say that the string includes non-digit characters?

How about: "The identifier is an opaque string; frontends should not
try to convert it to integer".


Thanks,

-- 
Vladimir Prus
CodeSourcery
vladimir@codesourcery.com
(650) 331-3385 x722