This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Exit gdb/configure.tgt for unsupported targets


On 02/24/2010 06:00 PM, Ralf Corsepius wrote:
On 02/24/2010 05:51 PM, Tom Tromey wrote:
"Ralf" == Ralf Corsepius<ralf.corsepius@rtems.org> writes:
Ralf> 2010-02-23 Ralf CorsÃpius<ralf.corsepius@rtems.org>
Ralf> * configure.tgt: Exit if ${gdb_target_obs}" is not set.

Ralf> +if test -z "${gdb_target_obs}"; then
Ralf> + echo "*** Configuration ${targ} is unsupported.">&2
Ralf> + exit 1
Ralf> +fi

I think it would be better to do the test in configure.ac and use
AC_MSG_ERROR.
I wasn't aware "${gdb_target_obs}" is exported to configure.ac and
intended to keep configure.tgt self-contained ;)

Now that it apparently is exported and used in configure.ac, I agree
with you, configure.ac+AC_MSG_ERROR would be better.

Reworked patch enclosed below.


Ralf


Attachment: gdb-7.0.90-gdb-configure.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]