This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Make mips-linux signal frame unwinding more robust.


On Fri, Feb 26, 2010 at 10:22:09AM -0800, David Daney wrote:
>   The current signal frame unwinding code in mips-linux-tdep.c assumes
>   a constant offset from the signal return trampoline to the signal
>   frame. The assumption does not hold for all kernels.  Specifically
>   those that have to be compiled with ICACHE_REFILLS_WORKAROUND_WAR
>   set (SGI O2 for example).  In the near future, it is likely that the
>   assumption will cease to hold universally, as we are attempting to
>   move the signal return trampoline off the stack entirely.

It's funny, I thought I'd already taught GDB about the WAR workaround,
but there's no hint of it.  Your patch looks good to me.

> OK to commit?
> 
> How about on the 7.1 branch?

OK both.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]