This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Somewhat sanitize watchpoints with conditions on local expressions
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Pedro Alves <pedro at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 04 Mar 2010 02:55:26 -0500
- Subject: Re: Somewhat sanitize watchpoints with conditions on local expressions
- References: <201003040350.34417.pedro@codesourcery.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Pedro Alves <pedro@codesourcery.com>
> Date: Thu, 4 Mar 2010 03:50:34 +0000
>
> The patch below that implements what sounded least
> surprising to me (evaluate condition in correct frame
> if possible, and warn if not possible, without trying
> and doing undefined things), and adds tests
> for this, and other variants involving global
> expressions, and local conditions.
>
>
> Comments?
I like it. One question:
> +static int
> +is_watchpoint (struct breakpoint *bpt)
> +{
> + return (is_hardware_watchpoint (bpt)
> + || bpt->type == bp_watchpoint);
> +}
Does this catch read and access watchpoints? Should it?
Thanks.