This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFA] dwarf2_physname FINAL


Hi,

Okay, now that 7.1 has branch, it is time to give the go/no-go on this patch. I'm attaching the "final" version (in full this time, in case anyone wants to apply it to their own sandbox).

The only "new" stuff in this patch is a fixlet to py-symbol.exp, in which a test prints out the linkage name (which has obviously changed).

There is an apparent regression in jprint.exp. Printing static class variables (java only) is "broken." This is a gcc bug (gcc/43260): we don't get any location info from gcc about where the static variable lives, so we report it as "optimized out." NOTE: This "works" on CVS HEAD because we fallback to using the linkage name (from DW_AT_MIPS_linkage_name) to search the minimal symbol table, using that to grab the address of the variable. Obviously we won't be able to do that any more.

One other issue that I uncovered: DW_AT_MIPS_linkage_name appears to be necessary for Ada. I have a patch that I used to address this (for one of our internal releases), but it is probably not complete. [In other words: it's now just as broken as it was before.] I can submit this as a follow-up, if so desired.

I have tested the attached patch against i686-linux-gnu (Fedora 11) and Jan has kindly tested it in his usual array of configurations ({x86_64,x86_64-m32,i686}-fedora{11,12,13}-linux-gnu) with no regressions (other than the aforementioned jprint.exp static variable failure).

Final comments/questions/concerns?

Keith

[I'm omitting the ChangeLog -- you've seen it before]

Attachment: dwarf2_physname-full-3.patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]