This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] dwarf2_physname FINAL
- From: Tom Tromey <tromey at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 05 Mar 2010 14:53:59 -0700
- Subject: Re: [RFA] dwarf2_physname FINAL
- References: <4B903926.7070303@redhat.com>
- Reply-to: tromey at redhat dot com
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> Okay, now that 7.1 has branch, it is time to give the go/no-go on this
Keith> patch. I'm attaching the "final" version (in full this time, in case
Keith> anyone wants to apply it to their own sandbox).
Keith> The only "new" stuff in this patch is a fixlet to py-symbol.exp, in
Keith> which a test prints out the linkage name (which has obviously
Keith> changed).
Given the earlier approvals, I think this is ok. Please check it in.
If there are lingering problems, we can fix them.
Keith> One other issue that I uncovered: DW_AT_MIPS_linkage_name appears to
Keith> be necessary for Ada. I have a patch that I used to address this (for
Keith> one of our internal releases), but it is probably not complete. [In
Keith> other words: it's now just as broken as it was before.] I can submit
Keith> this as a follow-up, if so desired.
By this, I assume you mean that after your patch, Ada continues to work,
but still uses DW_AT_MIPS_linkage_name; and that you have a follow-on
patch that is incomplete but which attempts to remove the reliance on
DW_AT_MIPS_linkage_name?
thanks,
Tom