This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFC: Verify AT_ENTRY before using it
- From: Daniel Jacobowitz <dan at codesourcery dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 8 Mar 2010 17:06:35 -0500
- Subject: Re: RFC: Verify AT_ENTRY before using it
- References: <20100224224913.GA25437@caradoc.them.org> <20100225221620.GA7830@host0.dyn.jankratochvil.net> <20100226211216.GC2630@caradoc.them.org> <20100301200428.GA14079@host0.dyn.jankratochvil.net>
On Mon, Mar 01, 2010 at 09:04:28PM +0100, Jan Kratochvil wrote:
> The patch below combines (a)+(c)+(b) (in this order). It also implements
> a warning on non-matching exec_bfd vs. target memory. (d) is still left as
> applicable independent patch for approval.
Thanks for working on this. I agree with all of it except the
warnings. Since there's no other working way to accomplish (d)
today, and I have a use case for that which won't go away, I don't
think it's appropriate to warn.
Note, if the program headers matched but the alignment was not page
aligned, that would be a different case: that seems worth warning
about. I don't know what that would mean. Is it a case you've
encountered?
Without the warnings, this is OK to check in. If you want the
warnings, we should discuss it a little more.
--
Daniel Jacobowitz
CodeSourcery