This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix remote-fileio.c compilation for Cygwin 1.5 API
- From: Christopher Faylor <cgf-use-the-mailinglist-please at sourceware dot org>
- To: gdb-patches at sourceware dot org, Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Date: Wed, 10 Mar 2010 10:57:29 -0500
- Subject: Re: [RFA] Fix remote-fileio.c compilation for Cygwin 1.5 API
- References: <000901cabeda$3cd7bd00$b6873700$@muller@ics-cnrs.unistra.fr> <20100308200858.GA28304@caradoc.them.org> <20100308214856.GA18247@ednor.casa.cgf.cx> <000f01cabf16$07402330$15c06990$@muller@ics-cnrs.unistra.fr> <20100309191512.GB2977@ednor.casa.cgf.cx> <000901cabfe3$43c6bda0$cb5438e0$@muller@ics-cnrs.unistra.fr>
On Wed, Mar 10, 2010 at 12:50:14AM +0100, Pierre Muller wrote:
>Hi Christopher,
>> >I just discovered for windows-nat.c
>> >
>> >See http://sourceware.org/ml/gdb-patches/2010-03/msg00344.html
>>
>> You're right. My macro was too simple minded. I've checked in your
>> change to windows-nat.c. If you want to use that in remote-fileio.c
>> that's fine. Or not. It really isn't a big deal either way.
>Thanks for the check-in.
>
> OK, here is a new, lighter version of the remote-fileio.c patch...
>There is also a small problem remaining for windows-nat.c
>(the previous definition of the cygwin_conv_path macro
>needs to be removed).
>
>Is this patch OK?
>
>Pierre
>
>2010-03-10 Pierre Muller <muller@ics.u-strasbg.fr>
>
> * remote-fileio.c (cygwin_conv_path): Define macro for old cygwin
>API.
> * windows-nat.c (cygwin_conv_path): Remove old macro.
I've checked in the windows-nat.c change. The remote-fileio.c change looks
good to me.
cgf