This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [MI tracepoints 7/9] -trace-find
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: Vladimir Prus <vladimir at codesourcery dot com>
- Date: Tue, 16 Mar 2010 00:27:53 +0000
- Subject: Re: [MI tracepoints 7/9] -trace-find
- References: <201003141159.44482.vladimir@codesourcery.com>
I stopped a few minor issues.
On Sunday 14 March 2010 08:59:44, Vladimir Prus wrote:
> + error ("May not look at trace frames while trace is running.");
Missing i18n.
> + else if (strcmp (mode, "tracepoint-number") == 0)
> + {
> + if (argc != 2)
> + error (_("frame number is required"));
> + tfind_1 (tfind_tp, atoi (argv[1]), 0, 0, 0);
> + }
You mean, "tracepoint number is required".
On Sunday 14 March 2010 08:59:44, Vladimir Prus wrote:
> - TPP. */
> + TPP. If no trace frame matches, return -1. ay throw if the
^^^
"-1. May throw"
--
Pedro Alves