This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [MI tracepoints 2/9] unify breakpoint commands and tracepoint actions
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: Vladimir Prus <vladimir at codesourcery dot com>
- Date: Tue, 16 Mar 2010 00:56:13 +0000
- Subject: Re: [MI tracepoints 2/9] unify breakpoint commands and tracepoint actions
- References: <201003141147.34051.vladimir@codesourcery.com>
Is this the final patch? I ask because I'm seeing some of the same
issues that I pointed out before offlist.
On Sunday 14 March 2010 08:47:33, Vladimir Prus wrote:
> + /** We need to verify that each top-level element of commands
> + is valid for tracepoints, that there's at most one while-stepping
> +#gdb_test "info tracepoints" \
> +# "Num Type\[ \]+Disp Enb Address\[ \]+What.*
> +#.*while-stepping $stepcount.*" \
> +
> +
> +
Please also fix this:
> @@ -252,6 +252,8 @@ mi_cmd_break_commands (char *command, char **argv, int argc)
> int bnum;
> struct breakpoint *b;
>
> + extern void check_tracepoint_command (char *line, void *closure);
This is not a review.
--
Pedro Alves