This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Why does ui_out_field_core_addr pad with leading zeroes?
On Thu, Mar 18, 2010 at 12:51 PM, Daniel Jacobowitz
<dan@codesourcery.com> wrote:
> On Thu, Mar 18, 2010 at 12:38:09PM -0700, Doug Evans wrote:
>> 2010-03-18 ?Doug Evans ?<dje@google.com>
>>
>> ? ? ? ? * ui-out.c (ui_out_field_core_addr): Don't pad address with leading
>> ? ? ? ? zeroes.
>> ? ? ? ? * breakpoint.c (breakpoint_1): Right align breakpoint addresses.
>
> Does this right align the header, or just the contents?
>
> I may be alone, and at risk of bikeshedding, but I think this looks
> weird:
>
> Num ? ? ? ? Address
> 1 ? ? ? ? ? ?0x4414
> 2 ? ? ?0x1231230000
>
> I'm more a fan of:
>
> Num ?Address
> 1 ? ? ? ? ? ? ? 0x4414
> 2 ? ? ? ? 0x1231230000
Would you left justify all headers with right-justified data?
Or should ui-out support differentiating header justification with the data's?
Feels like a stretch to me.
> [They both look a bit weird to me though. ?My ideal UI for this stuff
> resizes based on contents...]
Yeah.