This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] gdbserver support for qCRC: (compare-sections)
On Tuesday 23 March 2010 22:44:20, Michael Snyder wrote:
> OK, committed, thanks.
The checked in version has a new bug:
> + if (strncmp ("qCRC:", own_buf, 5) == 0)
> + {
> + /* CRC check (compare-section). */
> + char *comma;
> + CORE_ADDR base;
> + int len;
> + unsigned long long crc;
> +
> + require_running (own_buf);
> + base == strtoul (own_buf + 5, &comma, 16);
^^
You meant to make that an assignment, not a comparison.
Thou shall always test what you commit. ;-)
> + if (*comma++ != ',')
> + {
--
Pedro Alves