This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Add xmlRegisters= to qsupported query


> Date: Sun, 28 Mar 2010 16:46:43 -0700
> From: "H.J. Lu" <hongjiu.lu@intel.com>
> 
> 2010-03-28  H.J. Lu  <hongjiu.lu@intel.com>
> 
> 	* gdb.texinfo (General Query Packets): Add xmlRegisters.

I have a few comments to the documentation part:

> +@item xmlRegisters
> +This feature indicates that @value{GDBN} supports supports the XML
                                            ^^^^^^^^^^^^^^^^^
two "supports" in a row.

> +target description.  If the stub sees @samp{xmlRegisters=} with
> +target specfic strings separated by comma, it can send @value{GDBN}
                                    ^^^^^^^^
"by a comma".  Also, what do you mean by "it can send", why "can"?
Doesn't it always send the XML description?

> @@ -5943,6 +5944,9 @@ i386_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
>    set_gdbarch_fast_tracepoint_valid_at (gdbarch,
>  					i386_fast_tracepoint_valid_at);
>  
> +  /* Tell remote stub that we support XML target description.  */
> +  register_remote_support_xml ("x86");

A possibly dumb question: what effect will this change in i386-tdep.c
have on i386 targets that don't support remote debugging?  How about
if GDB was built without libexpat?


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]