This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH v2] sim: fix printf format warning about non-string literal
- From: Mike Frysinger <vapier at gentoo dot org>
- To: gdb-patches at sourceware dot org
- Date: Mon, 29 Mar 2010 19:11:38 -0400
- Subject: [PATCH v2] sim: fix printf format warning about non-string literal
- References: <1269903237-11061-1-git-send-email-vapier@gentoo.org>
This is the normal "passing a buffer straight to printf makes GCC warn".
While we know this particular case is fine, the trend in this source tree
is to fix this anyways to avoid the warnings.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
v2
- also fix same issue in hw_option_handler()
2010-03-29 Mike Frysinger <vapier@gentoo.org>
* sim-utils.c (sim_io_eprintf_cpu): Use %s with printf string.
* sim-hw.c (hw_option_handler): Likewise.
sim/common/sim-hw.c | 2 +-
sim/common/sim-utils.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sim/common/sim-hw.c b/sim/common/sim-hw.c
index d9868d3..7481492 100644
--- a/sim/common/sim-hw.c
+++ b/sim/common/sim-hw.c
@@ -257,7 +257,7 @@ hw_option_handler (struct sim_state *sd, sim_cpu *cpu, int opt,
case OPTION_HW_DEVICE:
{
- hw_tree_parse (STATE_HW (sd)->tree, arg);
+ hw_tree_parse (STATE_HW (sd)->tree, "%s", arg);
return SIM_RC_OK;
}
diff --git a/sim/common/sim-utils.c b/sim/common/sim-utils.c
index fb84eb3..9f9104e 100644
--- a/sim/common/sim-utils.c
+++ b/sim/common/sim-utils.c
@@ -170,7 +170,7 @@ sim_io_eprintf_cpu (sim_cpu *cpu, const char *fmt, ...)
va_list ap;
va_start (ap, fmt);
- sim_io_eprintf (sd, sim_cpu_msg_prefix (cpu));
+ sim_io_eprintf (sd, "%s", sim_cpu_msg_prefix (cpu));
sim_io_evprintf (sd, fmt, ap);
va_end (ap);
}
--
1.7.0.2