This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[commit] make fail/pass texts match in gdb.base/annota1.exp


Hi.

I checked in this tweak to annota1.exp.
A better patch would be to do something like what lineinc.exp does

set test_name "..."

and then refer to it everytime.
annota1.exp has lots of tests and I gather it should be using
gdb_test_multiple instead of send_gdb/gdb_expect, thus a large
cleanup should include that too, and I didn't have time for that right now.

2010-03-30  Doug Evans  <dje@google.com>

	* gdb.base/annota1.exp (break handle_USR1): Make fail and pass text
	match.
	(break printf): Ditto.

Index: gdb.base/annota1.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/annota1.exp,v
retrieving revision 1.36
diff -u -p -r1.36 annota1.exp
--- gdb.base/annota1.exp	1 Jan 2010 07:32:00 -0000	1.36
+++ gdb.base/annota1.exp	30 Mar 2010 22:09:44 -0000
@@ -218,9 +218,9 @@ gdb_expect {
 send_gdb "break handle_USR1\n"
 gdb_expect {
   -re  "\r\n\032\032post-prompt\r\n\r\n\032\032breakpoints-invalid\r\nBreakpoint.*at $hex: file.*$srcfile, line.*\r\n$gdb_prompt$" \
-	    { pass "breakpoint handle_USR1" }
-  -re ".*$gdb_prompt$"     { fail "break at handle_USR1" }
-  timeout	            { fail "break at handle_USR1 (timeout)" }
+	    { pass "break handle_USR1" }
+  -re ".*$gdb_prompt$"     { fail "break handle_USR1" }
+  timeout	            { fail "break handle_USR1 (timeout)" }
 }
 
 #
@@ -229,9 +229,9 @@ gdb_expect {
 send_gdb "break printf\n"
 gdb_expect {
   -re  "\r\n\032\032post-prompt\r\n\r\n\032\032breakpoints-invalid\r\nBreakpoint.*at $hex.*$gdb_prompt$" \
-	    { pass "breakpoint printf" }
+	    { pass "break printf" }
   -re  "\r\n\032\032post-prompt\r\nwarning: Breakpoint address adjusted from $hex to $hex.\r\n\r\n\032\032breakpoints-invalid\r\nBreakpoint.*at $hex.*$gdb_prompt$" \
-	    { pass "breakpoint printf"}
+	    { pass "break printf" }
   -re ".*$gdb_prompt$"     { fail "break printf" }
   timeout	            { fail "break printf (timeout)" }
 }


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]