This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[cancel] Re: [patch] Fix crash on NULL rl_prompt

From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
To: Pedro Alves <pedro at codesourcery dot com>
Cc: tromey at redhat dot com, gdb-patches at sourceware dot org
Date: Wed, 31 Mar 2010 23:22:06 +0200
Subject: [cancel] Re: [patch] Fix crash on NULL rl_prompt
References: <20100329234026.GA23895@host0.dyn.jankratochvil.net> <201003301825.18754.pedro@codesourcery.com> <20100330172940.GA17534@host0.dyn.jankratochvil.net> <201003301855.08267.pedro@codesourcery.com>

On Tue, 30 Mar 2010 19:55:08 +0200, Pedro Alves wrote:
> On Tuesday 30 March 2010 18:30:48, Tom Tromey wrote:
> > We can always un-approve it, if you would rather wait to see if a
> > reproducer is available.
> 
> I'll leave it up to you to decide.  But if this goes in,
> perhaps a comment saying this is being defensive would be good.

Found the problem was most probably due to a Fedora patch posted here without
the FSF GDB acceptance intention:
	[gdb FYI-patch] callback-mode readline-6.0 regression
	http://sourceware.org/ml/gdb-patches/2009-11/msg00596.html

That patch is needed only with readline-6.0 and neither with 5.1 nor 6.1.
That patch accidentally did rl_set_prompt (NULL).

(FSF GDB should import readline-6.1 but that is offtopic in this thread.)

Therefore not going to check-in this patch.


Thanks,
Jan

References:
- [patch] Fix crash on NULL rl_prompt
  - From: Jan Kratochvil
- Re: [patch] Fix crash on NULL rl_prompt
  - From: Pedro Alves
- Re: [patch] Fix crash on NULL rl_prompt
  - From: Jan Kratochvil
- Re: [patch] Fix crash on NULL rl_prompt
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]