This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Use vectors in uploaded tracepoints
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Stan Shebs <stan at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 5 Apr 2010 13:50:28 -0700
- Subject: Re: [PATCH] Use vectors in uploaded tracepoints
- References: <4BBA3E00.7060508@codesourcery.com>
FWIW...
> 1. This is now the third place that has a "char_ptr" typedef for use
> with vectors. Is there any reason not to consolidate into one
> typedef in defs.h?
Certainly no objection on this end, although the benefits seem to be
pretty small. Perhaps it would make even better sense if we added both
the char_ptr and the vector definition? Would that have any negative
effect in terms of amount of code?
> 2. Should it be renamed to "char_p"? There is a quasi-standard of
> using "_s" for struct and "_p" for pointer typedefs for vectors; but
> "char_p" seems a little cryptic to me.
If char_p is defined together with the associated vector, then I don't
mind it. But defined on its own, I agree char_ptr is better.
(not that it really matters all that much...)
--
Joel