This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [RFA] ARI fix: remove remaining %ll occurences.
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: "'Joel Brobecker'" <brobecker at adacore dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Tue, 6 Apr 2010 00:19:16 +0200
- Subject: RE: [RFA] ARI fix: remove remaining %ll occurences.
- References: <002401cad1ab$a8163180$f8429480$@muller@ics-cnrs.unistra.fr> <20100405163845.GE19194@adacore.com>
> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Joel Brobecker
> Envoyé?: Monday, April 05, 2010 6:39 PM
> À?: Pierre Muller
> Cc?: gdb-patches@sourceware.org
> Objet?: Re: [RFA] ARI fix: remove remaining %ll occurences.
>
> > As there is no way LONGEST can be specified for scanf,
> > I took the option to allow %ll inside scanf calls.
>
> I don't have a better alternative to propose. Since this does not seem
> to be a portability issue so far, I'm OK with that.
Great, I updated the gdb_ari.sh for this.
> > 2010-04-01 Pierre Muller <muller@ics.u-strasbg.fr>
> >
> > Remove remaining "%ll" uses.
> > * go32-nat.c (go32_pte_for_address): Replace "0x%llx" using
> > hex_string call.
> > * rs6000-nat.c (rs6000_ptrace64): Idem.
> > * solib-pa64.c (pa64_current_sos): Idem.
> > * solib-spu.c (spu_current_sos): Idem.
> > * linux-nat.c (linux_nat_find_memory_regions): Replace "%lld"
> using
> > plongest call.
> > * nto-procfs.c (procfs_meminfo): Replace "0x%016llx" using
> > phex (VAR, 8) call.
> > * sh64-tdep.c (sh64_show_media_regs): Idem.
>
> Just one typo, but otherwise approved. Thank you for doing that.
>
> > - ("PC=%s SR=%016llx \n",
> > + ("PC=%s SR=%s \n",
> > phex (get_frame_register_unsigned (frame,
> > gdbarch_pc_regnum (gdbarch)), 8),
> > - (long long) get_frame_register_unsigned (frame, SR_REGNUM));
> > + phex (get_frame_register_unsigned (frame, SR_REGNUM), 9));
> ^^^^
> Typo: Should be 8.
Whoops, my hands are not precise enough for a keyboard, it seems...
Committed with that change,
Thanks Joel,
Pierre