This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Fix deadlock on looped solib list
- From: Tom Tromey <tromey at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 07 Apr 2010 13:47:09 -0600
- Subject: Re: [patch] Fix deadlock on looped solib list
- References: <20100403092301.GA21485@host0.dyn.jankratochvil.net>
- Reply-to: tromey at redhat dot com
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> While some simple n^2 check or maximal allowed libraries list could
Jan> be more simple remembering Google was patching GDB for very large
Jan> solib lists.
I don't remember hearing about this... anybody know why this isn't
in the FSF GDB?
Jan> gdb/
Jan> 2010-04-03 Jan Kratochvil <jan.kratochvil@redhat.com>
Jan> Fix deadlock on looped list of loaded shared objects.
Jan> * arch-utils.c (core_addr_hash, core_addr_eq): New.
Jan> * arch-utils.h: Include hashtab.h.
Jan> (core_addr_hash, core_addr_eq): New prototypes.
Jan> * defs.h: Include hashtab.h.
Jan> (make_cleanup_htab_delete): New prototype.
Jan> * solib-svr4.c: Include arch-utils.h.
Jan> (svr4_current_sos): New variables lm_obstack, lm_hash, outer_chain,
Jan> initialize them, call outer_chain do_cleanups at the bottom. Move new
Jan> and old_chain initializations after a new duplicity check of LM using
Jan> new variable lm_slot.
Jan> * utils.c (do_htab_delete_cleanup, make_cleanup_htab_delete): New.
This is ok. Thanks.
Tom