This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH/RFC] Include value of default-collect in breakpoint/tracepoint list
- From: Tom Tromey <tromey at redhat dot com>
- To: Stan Shebs <stan at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 07 Apr 2010 13:55:57 -0600
- Subject: Re: [PATCH/RFC] Include value of default-collect in breakpoint/tracepoint list
- References: <4BBA7264.5060109@codesourcery.com>
- Reply-to: tromey at redhat dot com
>>>>> "Stan" == Stan Shebs <stan@codesourcery.com> writes:
Stan> 2010-04-05 Stan Shebs <stan@codesourcery.com>
Stan> * breakpoint.c (default_collect_info): New function.
Stan> (breakpoints_info): Call it.
Stan> (maintenance_info_breakpoints): Ditto.
Stan> (tracepoints_info): Ditto.
Stan> + static void default_collect_info (void);
Stan> + /* Display the value of default-collect in a way that is generally
Stan> + compatible with the breakpoint list. */
Stan> +
Stan> + void
Stan> + default_collect_info (void)
It is mildly weird for the declaration to have 'static' but not the
definition.
Also, I think the preferred style nowadays is to order functions so that
we don't need forward declarations (when possible).
FWIW, and since you asked, I think the idea behind the patch seems fine.
Tom