This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: PR corefiles/11481: gcore doesn't work on i386 without SSE


Mark already answered, but I noticed something that was perhaps worth
a suggestion:

> +  if (i386_linux_regset_sections[i].sect_name == NULL)
> +    internal_error (__FILE__, __LINE__,
> +		    _("invalid core regset secion %s"), name);

In this sort of situation (something that should never happen unless
there is a programming error in GDB), you might prefer the use of
gdb_assert.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]