This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch, rfc] Re: MIPS dwarf2 location lists
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Ulrich Weigand <uweigand at de dot ibm dot com>
- Cc: gdb-patches at sourceware dot org, Daniel Jacobowitz <dan at codesourcery dot com>
- Date: Mon, 12 Apr 2010 13:23:37 -0700
- Subject: Re: [patch, rfc] Re: MIPS dwarf2 location lists
- References: <201003031955.o23Jtp4w007044@d12av02.megacenter.de.ibm.com> <201004091615.o39GFgl3032201@d12av02.megacenter.de.ibm.com>
> > * dwarf2expr.c (dwarf2_read_address): Make static.
> > * dwarf2expr.h (dwarf2_read_address): Remove prototype.
> > * dwarf2loc.c (find_location_expression): Add relocation offset
> > to base-address-selection entry base addresses. Read addresses
> > (and offsets) as signed/unsigned integers, depending on the
> > BFD's sign_extend_vma flag. Do not call dwarf2_read_address.
> > (locexpr_describe_location): Read TLS offset as unsigned
> > integer. Do not call dwarf2_read_address.
>
> Ping. Any thoughts on whether we should go with this?
Can't really say much about the patch itself; but FWIW, I tested it
on mips-irix, and saw no regression.
--
Joel