This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Michael Snyder wrote:Michael Snyder wrote:Pedro Alves wrote:On Thursday 15 April 2010 19:58:44, Michael Snyder wrote:Fair enough.Oh -- and on reload, some of them fail?We save them.OTOH, it may be useful to be able to dump watchpoints on locals, and be able to load them up when you know it's okay, so never dumping those isn't that great either. So, IMO, we shouldn't worry much about those, at least, in this first patch. :-) I could add a note to the manual, perhaps.That's cool. So what do we do now? Just skip them? Save the global ones, skip the local ones?
Shouldn't be difficult to skip saving all of them, but what about skipping the locals and saving the globals? Hard?As I said above, it may be useful to be able to dump watchpoints on locals, and be able to load them up when you know it's okay, so never dumping those isn't that great either. It's not hard, it's just not always the right thing. As is, the user can edit the script if the wants to zap some breakpoints before sourcing it. It's just a CLI script. If you want to add a new command switch to tune the behaviour, that'd be cool.
BTW. "save_command" needs to print an error or something, not simply return without doing anything. If I type "save<return>", I get a silent failure.
... or perhaps "save" should be aliased to "save-tracepoints", to mimic the previous behavior.
Also maybe this should be milder than a warning:
if (!any) { if (from_tty) printf_filtered (_("Nothing to save.")); return; }
Also, it doesn't seem right to me that "save tracepoints" will ignore breakpoints, but "save breakpoints" doesn't ignore tracepoints (but rather saves them both).
Since you have this filter mechanism in place already, why don't you arrange to have "save breakpoints" save only breakpoints?
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |