This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH]: gdb: fdpic/frv: fix shared library loading
- From: Kevin Buettner <kevinb at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Fri, 16 Apr 2010 15:22:28 -0700
- Subject: Re: [PATCH]: gdb: fdpic/frv: fix shared library loading
- References: <201004140259.39671.vapier@gentoo.org>
On Wed, 14 Apr 2010 02:59:38 -0400
Mike Frysinger <vapier@gentoo.org> wrote:
> 2010-04-14 Mike Frysinger <vapier@gentoo.org>
>
> * solib-frv.c (enable_break1_done): Delete.
> (enable_break2): Do not check enable_break1_done. Move the
> enable_break2_done setting and call to
> remove_solib_event_breakpoints() to the end. Return without
> warning when the contents of _dl_debug_addr are 0.
> (enable_break): Do not set enable_break1_done.
> (frv_clear_solib): Likewise.
Okay, except for...
> + /* First, remove all the solib event breakpoints. Their addresses
> + may have changed since the last time we ran the program. */
> + remove_solib_event_breakpoints ();
...this comment. Just change it to read "Remove all the solib...". (It's
not happening first anymore.)
Feel free to commit it after revising that comment.
Kevin