This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb: objc-lang: check symbol name before accessing memory
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 19 Apr 2010 10:55:03 -0400
- Subject: Re: [PATCH] gdb: objc-lang: check symbol name before accessing memory
- References: <1271217554-28436-1-git-send-email-vapier@gentoo.org>
> 2010-04-13 Mike Frysinger <vapier@gentoo.org>
>
> * objc-lang.c (find_methods): Move symname check up.
This is OK, but I would like you to add a comment before the symbol name
check explaining that this check is performed first because it can be
performed entirely without sending any query to the target.
Can you also confirm how you tested this patch, please?
--
Joel