Re: [PATCH] sim: add --model-info helper option

[Mike Frysinger <vapier at gentoo dot org>]

On Sunday 18 April 2010 03:47:34 Doug Evans wrote:
> I believe you want NULL for the doc member of "info-model":
> 
>  +  { {"info-model", no_argument, NULL, OPTION_MODEL_INFO},
>  +      '\0', NULL, "List selectable models",
> 
> "List selectable models" should be NULL.
> At least according to sim-options.h:
> 
>      If DOC is NULL, this option name is listed as a synonym for the
>      previous option.

cool, i wasnt aware of this feature

> Also, I think you want the last printf of "\n" inside the outer for loop:
> 
>  +       sim_io_printf (sd, "\n");

indeed

> This patch is ok with these changes.

OK, committed then, thanks
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.