This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH/pascal] Fix pascal display of integer arrays PR 11492.
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: <gdb-patches at sourceware dot org>
- Cc: "'Joost van der Sluis'" <joost at cnoc dot nl>
- Date: Wed, 21 Apr 2010 11:55:30 +0200
- Subject: [PATCH/pascal] Fix pascal display of integer arrays PR 11492.
This patch fixes
the bug report PR 11492
http://sourceware.org/bugzilla/show_bug.cgi?id=11492
Checked in after testing on
gcc16 compile farm.
Pierre Muller
Pascal language support maintainer for GDB
2010-04-21 Pierre Muller <muller@ics.u-strasbg.fr>
PR pascal/11492.
* p-valprint.c (pascal_val_print): Fix default printing of integer
arrays.
testsuite/ChangeLog entry:
2010-04-21 Pierre Muller <muller@ics.u-strasbg.fr>
PR pascal/11492.
* gdb.pascal/gdb11492.pas: New file.
* gdb.pascal/gdb11492.exp: New file.
Index: src/gdb/p-valprint.c
===================================================================
RCS file: /cvs/src/src/gdb/p-valprint.c,v
retrieving revision 1.68
diff -u -p -r1.68 p-valprint.c
--- src/gdb/p-valprint.c 9 Mar 2010 08:30:54 -0000 1.68
+++ src/gdb/p-valprint.c 21 Apr 2010 07:49:41 -0000
@@ -80,12 +80,13 @@ pascal_val_print (struct type *type, con
{
print_spaces_filtered (2 + 2 * recurse, stream);
}
- /* For an array of chars, print with string syntax. */
- if ((eltlen == 1 || eltlen == 2 || eltlen == 4)
- && ((TYPE_CODE (elttype) == TYPE_CODE_INT)
- || ((current_language->la_language == language_pascal)
- && (TYPE_CODE (elttype) == TYPE_CODE_CHAR)))
- && (options->format == 0 || options->format == 's'))
+ /* If 's' format is used, try to print out as string.
+ If no format is given, print as string if element type
+ is of TYPE_CODE_CHAR and element size is 1,2 or 4. */
+ if (options->format == 's'
+ || ((eltlen == 1 || eltlen == 2 || eltlen == 4)
+ && TYPE_CODE (elttype) == TYPE_CODE_CHAR
+ && options->format == 0))
{
/* If requested, look for the first null char and only print
elements up to it. */
Index: src/gdb/testsuite/gdb.pascal/gdb11492.exp
===================================================================
RCS file: testsuite/gdb.pascal/gdb11492.exp
diff -N testsuite/gdb.pascal/gdb11492.exp
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ src/gdb/testsuite/gdb.pascal/gdb11492.exp 21 Apr 2010 07:49:46 -0000
@@ -0,0 +1,60 @@
+# Copyright 2010 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+if $tracelevel then {
+ strace $tracelevel
+}
+
+load_lib "pascal.exp"
+
+set testfile "gdb11492"
+set srcfile ${testfile}.pas
+set binfile ${objdir}/${subdir}/${testfile}$EXEEXT
+
+if {[gdb_compile_pascal "${srcdir}/${subdir}/${srcfile}" "${binfile}"
executable [list debug ]] != "" } {
+ return -1
+}
+
+gdb_exit
+gdb_start
+gdb_reinitialize_dir $srcdir/$subdir
+gdb_load ${binfile}
+set bp_location1 [gdb_get_line_number "set breakpoint 1 here"]
+
+if { [gdb_breakpoint ${srcfile}:${bp_location1}] } {
+ pass "setting breakpoint 1"
+}
+
+# Verify that "start" lands inside the right procedure.
+if { [gdb_start_cmd] < 0 } {
+ untested start
+ return -1
+}
+
+gdb_test "" ".* at .*${srcfile}.*" "start"
+gdb_test "continue" ""
+
+gdb_test "print integer_array" " = {50, 51, 52, 53, 54, 55, 56, 57}"
+gdb_test "print /s integer_array" " = '23456789'"
+
+gdb_test "print char_array" " = '23456789'"
+gdb_test "print /d char_array" " = {50, 51, 52, 53, 54, 55, 56, 57}"
+gdb_test "print /x char_array" " = {0x32, 0x33, 0x34, 0x35, 0x36, 0x37,
0x38, 0x39}"
+# Use next two times to avoid GPC line numbering problem
+gdb_test "next" ""
+gdb_test "next" ""
+gdb_test "print char_array" " = '2345X789'"
+gdb_exit
+
Index: src/gdb/testsuite/gdb.pascal/gdb11492.pas
===================================================================
RCS file: testsuite/gdb.pascal/gdb11492.pas
diff -N testsuite/gdb.pascal/gdb11492.pas
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ src/gdb/testsuite/gdb.pascal/gdb11492.pas 21 Apr 2010 07:49:46 -0000
@@ -0,0 +1,40 @@
+{
+ Copyright 2010 Free Software Foundation, Inc.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>.
+}
+
+
+program test_gdb_11492;
+
+const
+ LowBound = 1;
+ HighBound = 8;
+var
+ integer_array : array[LowBound..HighBound] of integer;
+ char_array : array[LowBound..HighBound] of char;
+ i : integer;
+
+begin
+ for i:=LowBound to HighBound do
+ begin
+ integer_array[i]:=49+i;
+ char_array[i]:=char(49+i);
+ end;
+ i:=0; { set breakpoint 1 here }
+ char_array[5] := 'X';
+ Writeln('integer array, index 5 is ',integer_array[5]);
+ Writeln('char array, index 5 is ',char_array[5]);
+end.
+