This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: D language support

>>>>> "Mihail" == Mihail Zenkov <mihail.zenkov@gmail.com> writes:

Style nits...

Mihail> +extern void c_emit_char (int c, struct type *type, struct ui_file *stream, int quoter);

Must split this line.

Mihail> +d_demangle (const char* symbol, int options)

"char *", not "char* ".

Mihail> +  if (mangled_str[0] == '_' && mangled_str[1] == 'D')
Mihail> +    {
Mihail> +      mangled_str += 2;
Mihail> +      is_func = 1;
Mihail> +    }
Mihail> +    else if (strncmp (mangled_str, "__Class_", 8) == 0)
Mihail> +      mangled_str += 8;
Mihail> +    else if (strncmp (mangled_str, "__init_", 7) == 0)
Mihail> +      mangled_str += 7;

All the "else if"s are indented too far.

Tom
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]