Re: [gdb/libiberty] Improve support for cross debugging shared libraries with DOS style pathnames (from Unix hosts)

[Eli Zaretskii <eliz at gnu dot org>]

> From: Pedro Alves <pedro@codesourcery.com>
> Date: Sat, 24 Apr 2010 12:17:46 +0100
> Cc: gcc-patches@gcc.gnu.org
> 
> On Friday 23 April 2010 15:35:11, Eli Zaretskii wrote:
> > Not only is it clearer, it's in GNU coding standards, see my other
> > mail.
> 
> Okay, I changed all user visible strings, I think.

Thanks.

> > No, it's clear enough.  I just wondered why you didn't remove the
> > drive letter right away.  I guess that's common practice in some
> > quarters to mount DOS-ish filesystems that way.  I don't really mind
> > to support that if people are using it.
> 
> Hope you don't mind, I ended up extending the docs here to
> explicitly explain why the lookup algorith is the way it is,
> so that users don't wonder the same you did.

I don't mind, of course.  Thanks for the extra effort.

> I've moved that new target filesystem handling code to a
> new file, and, handled DJGPP's gdbarch.

Again, thanks.

> I think this updated patch addresses all your comments.  Could
> you please take a new quick look at this?

It's fine, I have only 2 minor nits to report:

> +Then, @value{GDBN} attempts prefixing the target file name with
> +@var{path}, and look for the resulting file name in the host file
> +system:         ^^^^

"looks"

> +@smallexample
> + @file{/path/to/sysroot/c/sys/bin/foo.dll}
> + @file{/path/to/sysroot/c/sys/bin/bar.dll}
> + @file{/path/to/sysroot/z/sys/bin/bar.dll}
> +@end smallexample
> +
> +and point the system root at @file{/path/to/sysroot}, so that

We need @noindent before the last line.