Re: [RFA- v2] Remove CANNOT_STEP_HW_WATCHPOINTS related code (was fix for bug 11531)

[Pedro Alves <pedro at codesourcery dot com>]

On Monday 26 April 2010 08:51:18, Pierre Muller wrote:
>   Is this patch OK?

This is going in circles, but, why didn't you remove the macro
definition and the whole comment around it from the nm file?
The goal is remove the whole workaround, so you should remove
that too.  The goal of the exercise is to keep each patch
self-contained.  I know you'll remove the nm file afterwards, but,
let's pretend you wouldn't, or that someone would reject that
patch of yours for some reason we haven't thought of yet --- you'll
still want the macro and the comments around it to, _not_ end up
defined in there after this patch.

On Monday 26 April 2010 08:51:18, Pierre Muller wrote:
>   In that case, the configure.tgt script should probably report 
> that Solaris versions <= 2.7 are not supported anymore.
> This is what I added to configure.tgt below.

...

> -i[34567]86-*-solaris*)
> -       # Target: Solaris x86
> +i[34567]86-*-solaris2.[8-9] )
> +       # Target: Solaris x86, only versions 2.8 and 2.9
> +       # Versions <= 2.7 suffer a bug that was handled in older versions of
> 
> +       # GDB, but that code was removed.

It may still work, provided the user doesn't set watchpoints...
In any case, this won't prevent someone building gdb on such
solaris', because you'll still hit the "i[34567]86-*-*)" case
below (and --enable-targets=all will still build the files you're
skipping anyway), leaving the user with a built, but very crippled
GDB, with no hint where to look at.  I suggest leaving this change out
of the patch and focusing on a single thing at a time, otherwise
we'll never get this done.

-- 
Pedro Alves